Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

David Faure faure at kde.org
Mon Sep 28 20:30:01 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125436/#review86070
-----------------------------------------------------------



src/widgets/koverlayiconplugin.desktop (line 3)
<https://git.reviewboard.kde.org/r/125436/#comment59380>

    Can we use a subdir of the plugins dir for overlayicons plugins rather than a trader query (which is "the old way" of discovering plugins)?



src/widgets/koverlayiconplugin.h (line 51)
<https://git.reviewboard.kde.org/r/125436/#comment59378>

    typo: recommended



src/widgets/koverlayiconplugin.h (line 53)
<https://git.reviewboard.kde.org/r/125436/#comment59379>

    typo: available


- David Faure


On Sept. 28, 2015, 9:14 a.m., Olivier Goffart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125436/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 9:14 a.m.)
> 
> 
> Review request for Dolphin and KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The interface from https://git.reviewboard.kde.org/r/125136/ moved into KIO.
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt 820cd34 
>   src/widgets/koverlayiconplugin.cpp PRE-CREATION 
>   src/widgets/koverlayiconplugin.desktop PRE-CREATION 
>   src/widgets/koverlayiconplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125436/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Goffart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150928/e5843221/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


More information about the kfm-devel mailing list