Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125436/#review86063
-----------------------------------------------------------



src/widgets/koverlayiconplugin.h (line 55)
<https://git.reviewboard.kde.org/r/125436/#comment59376>

    Is a plugin expected to return multiple overlays, and if so are consumers of this interface expected to stack them all together? In what order?
    
    How is multiple oevrlay plugins to be handled? all of them stacked together ? In what order?
    
    I am wondering if either a QList<QIcon> - or let the plugin do the squashing - just QIcon - is a better return value.
    
    the naming "getOverlays" feels a bit java-esque.
    oh. and should it be const?


I think I like the concept, and it feels like kio is the right home for it.

- Sune Vuorela


On Sept. 28, 2015, 9:14 a.m., Olivier Goffart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125436/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 9:14 a.m.)
> 
> 
> Review request for Dolphin and KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The interface from https://git.reviewboard.kde.org/r/125136/ moved into KIO.
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt 820cd34 
>   src/widgets/koverlayiconplugin.cpp PRE-CREATION 
>   src/widgets/koverlayiconplugin.desktop PRE-CREATION 
>   src/widgets/koverlayiconplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125436/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Goffart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150928/59b67232/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel