Review Request 125069: [patch] Port dolphin-plugins to KF5 without kdelibs4support

[Anthony Fieroni]

> On Септ. 15, 2015, 10:29 след обяд, Mark Gaiser wrote:
> > git/checkoutdialog.cpp, lines 252-254
> > <https://git.reviewboard.kde.org/r/125069/diff/1/?file=400479#file400479line252>
> >
> >     you lost the if (enableButton) case. You might want to change the if (!newNameError) to if (!newNameError || enableButton)
> >     
> >     Specially because the enableButton case sets the tooltip as empty string where you now have a "possible filled in, possibly empty" string (depending on the conditions above).

No, if enableButton is true tooltip is empty, no need to check it explicitly. I will make 2 separate diffs.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125069/#review85454
-----------------------------------------------------------


On Септ. 16, 2015, 11:05 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125069/
> -----------------------------------------------------------
> 
> (Updated Септ. 16, 2015, 11:05 след обяд)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Remove dependecy of kdelibs4support
> 
> 
> Diffs
> -----
> 
>   svn/fileviewsvnplugin.cpp faf6a0f 
>   svn/fileviewsvnplugin.h 2ba36bf 
>   svn/CMakeLists.txt 1627b92 
>   git/tagdialog.h 60563cd 
>   git/tagdialog.cpp 5da01ad 
>   git/pushdialog.cpp 1c82fa3 
>   git/pulldialog.cpp d51789e 
>   git/pushdialog.h 74da471 
>   git/pulldialog.h 861cb80 
>   git/fileviewgitplugin.h 3148b12 
>   git/fileviewgitplugin.cpp 7af37f0 
>   git/commitdialog.cpp 06222cf 
>   git/commitdialog.h dd5bfbf 
>   git/checkoutdialog.h 6d24c7d 
>   git/checkoutdialog.cpp 1eaecef 
>   git/CMakeLists.txt ea58c77 
>   CMakeLists.txt 76314bf 
> 
> Diff: https://git.reviewboard.kde.org/r/125069/diff/
> 
> 
> Testing
> -------
> 
> 1. KDialog to QDialog + QDialogButtonBox using convert-kdialog.pl
> 2. KLineEdit to QLineEdit
> 3. KTextEdit to QTextEdit
> 4. KVBox, KHBox to QWidget + QVBoxLayout, QWidget + QHBoxLayout using convert-kvbox.pl
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150926/daf24f94/attachment.htm>