Review Request 125069: [patch] Port dolphin-plugins to KF5 without kdelibs4support

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125069/#review85454
-----------------------------------------------------------



bazaar/fileviewbazaarplugin.cpp (lines 226 - 269)
<https://git.reviewboard.kde.org/r/125069/#comment59039>

    The changes here seems unrelated to porting away from kdelibs4support. You might want to pull this out and make a seperate reviewrequest for it.



git/checkoutdialog.cpp (line 46)
<https://git.reviewboard.kde.org/r/125069/#comment59040>

    Is this still an issue?
    Would be cool to fix this before committing it (assuming it is still an issue).



git/checkoutdialog.cpp (line 50)
<https://git.reviewboard.kde.org/r/125069/#comment59041>

    Whitespace nitpick. Just remove the spaces.



git/checkoutdialog.cpp (line 64)
<https://git.reviewboard.kde.org/r/125069/#comment59042>

    Quote from QComboBox editable doc:
    "By default, this property is false. The effect of editing depends on the insert policy."
    
    I think you can just leave this line out.



git/checkoutdialog.cpp (line 70)
<https://git.reviewboard.kde.org/r/125069/#comment59043>

    vice versa



git/checkoutdialog.cpp 
<https://git.reviewboard.kde.org/r/125069/#comment59045>

    you lost the if (enableButton) case. You might want to change the if (!newNameError) to if (!newNameError || enableButton)
    
    Specially because the enableButton case sets the tooltip as empty string where you now have a "possible filled in, possibly empty" string (depending on the conditions above).



git/commitdialog.cpp (line 49)
<https://git.reviewboard.kde.org/r/125069/#comment59046>

    whitespace nitpick.. Remove it.



git/fileviewgitplugin.cpp (lines 58 - 91)
<https://git.reviewboard.kde.org/r/125069/#comment59047>

    These seem unrelated. Please open a new reviewrequest for those if you want.



git/fileviewgitplugin.cpp (lines 159 - 160)
<https://git.reviewboard.kde.org/r/125069/#comment59048>

    vivce versa



git/fileviewgitplugin.cpp (lines 243 - 289)
<https://git.reviewboard.kde.org/r/125069/#comment59049>

    vice cersa



git/fileviewgitplugin.cpp (lines 319 - 320)
<https://git.reviewboard.kde.org/r/125069/#comment59050>

    vice versa



git/fileviewgitplugin.cpp (lines 346 - 359)
<https://git.reviewboard.kde.org/r/125069/#comment59051>

    vice versa



git/fileviewgitplugin.cpp (line 414)
<https://git.reviewboard.kde.org/r/125069/#comment59052>

    vice versa



git/fileviewgitplugin.cpp (lines 430 - 480)
<https://git.reviewboard.kde.org/r/125069/#comment59053>

    vice versa


I stopped reviewing when i was at about 60% of the changes.. There are too much unrelated changes there that don't directly relate to porting away from kdelibs4suport.
Could you split the diff in:
1. Just porting away from kdelibs4suport.
2. The individual improvements you made per plugin.

- Mark Gaiser


On sep 14, 2015, 6:12 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125069/
> -----------------------------------------------------------
> 
> (Updated sep 14, 2015, 6:12 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Remove dependecy of kdelibs4support
> 
> 
> Diffs
> -----
> 
>   git/pushdialog.h 74da471 
>   git/pulldialog.cpp 9219e82 
>   git/pulldialog.h 861cb80 
>   git/fileviewgitplugin.cpp 283b8bc 
>   git/commitdialog.cpp d2f6b30 
>   git/commitdialog.h dd5bfbf 
>   git/checkoutdialog.cpp acd98f5 
>   git/CMakeLists.txt ea58c77 
>   git/checkoutdialog.h 6d24c7d 
>   bazaar/fileviewbazaarplugin.cpp dfbd5c1 
>   CMakeLists.txt 76314bf 
>   git/pushdialog.cpp 5c36932 
>   git/tagdialog.h 60563cd 
>   git/tagdialog.cpp 3c44f64 
>   svn/CMakeLists.txt 1627b92 
>   svn/fileviewsvnplugin.h a1eda54 
>   svn/fileviewsvnplugin.cpp a7f92bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125069/diff/
> 
> 
> Testing
> -------
> 
> 1. KDialog to QDialog + QDialogButtonBox using convert-kdialog.pl
> 2. KLineEdit to QLineEdit
> 3. KTextEdit to QTextEdit
> 4. KVBox, KHBox to QWidget + QVBoxLayout, QWidget + QHBoxLayout using convert-kvbox.pl
> 5. Correct parsing remotes/ in pull/push dialogs
> 6. Added -a to git commit
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150915/d6c57fa5/attachment.htm>