Review Request 125383: [dolphin-plugins]Fix for adding issues for git plugin

Tomasz Bojczuk seelook at gmail.com
Sat Sep 26 15:05:45 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125383/
-----------------------------------------------------------

(Updated Wrz 26, 2015, 2:05 po poĊ‚udniu)


Review request for Dolphin.


Bugs: https://bugs.kde.org/show_bug.cgi?id=352625
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=352625


Repository: dolphin-plugins


Description
-------

This pach reverts my previous fix, which solved only side effect of the main problem.
Main problem is clearing QProcess working directory of 'git' command when context menu of a file is invoked.
Now working directory is set there instead of clearing. Then 'git' is capable to work with relative file paths.


Diffs (updated)
-----

  git/fileviewgitplugin.cpp 4b5b1c5 

Diff: https://git.reviewboard.kde.org/r/125383/diff/


Testing
-------

Of course....
I uses/using it "even" with real (production) projects.


Thanks,

Tomasz Bojczuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150926/9658e9f2/attachment.htm>


More information about the kfm-devel mailing list