Review Request 125383: [dolphin-plugins]Fix for adding issues for git plugin

[Emmanuel Pescosta]

> On Sept. 26, 2015, 12:23 p.m., Emmanuel Pescosta wrote:
> > git/fileviewgitplugin.cpp, line 275
> > <https://git.reviewboard.kde.org/r/125383/diff/1/?file=408259#file408259line275>
> >
> >     QDir().canonicalPath()
> 
> Tomasz Bojczuk wrote:
>     I didn't catch what You mean exactly, QFileInfo::absolutePath() gives dir name of a file on which context menu was invoked. 
>     Should be this path wrapped by canonicalPath() of QDir?

use QDir().canonicalPath() instead of QFileInfo::absolutePath() -> Eliminates symlinks when possible


> On Sept. 26, 2015, 12:23 p.m., Emmanuel Pescosta wrote:
> > git/fileviewgitplugin.cpp, line 627
> > <https://git.reviewboard.kde.org/r/125383/diff/1/?file=408259#file408259line627>
> >
> >     Please remove this change and use git revert instead ;)
> 
> Tomasz Bojczuk wrote:
>     Please, do it in my behalf, I have not such powers yet.... I will ask for write access soon.

Ok, but please remove it from this patch as well ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125383/#review85949
-----------------------------------------------------------


On Sept. 24, 2015, 10:04 p.m., Tomasz Bojczuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125383/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 10:04 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=352625
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=352625
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> This pach reverts my previous fix, which solved only side effect of the main problem.
> Main problem is clearing QProcess working directory of 'git' command when context menu of a file is invoked.
> Now working directory is set there instead of clearing. Then 'git' is capable to work with relative file paths.
> 
> 
> Diffs
> -----
> 
>   git/fileviewgitplugin.cpp 7af37f0 
> 
> Diff: https://git.reviewboard.kde.org/r/125383/diff/
> 
> 
> Testing
> -------
> 
> Of course....
> I uses/using it "even" with real (production) projects.
> 
> 
> Thanks,
> 
> Tomasz Bojczuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150926/c3b1ca03/attachment.htm>