Review Request 125094: Adding icon to show hidden files

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125094/#review85964
-----------------------------------------------------------


Thanks for the patch and sorry for the late reply.

I'm not sure if 'Conceal' and 'Reveal' are better than 'Hide/Show Hidden Files'. 
Maybe we should just name it 'Hidden Files' and change only the icon and tool tip text? 
What do you/others think? ;)


src/views/dolphinviewactionhandler.cpp (line 211)
<https://git.reviewboard.kde.org/r/125094/#comment59316>

    Why no toggle action anymore?



src/views/dolphinviewactionhandler.cpp (line 212)
<https://git.reviewboard.kde.org/r/125094/#comment59317>

    Set a default text and icon please



src/views/dolphinviewactionhandler.cpp (lines 380 - 391)
<https://git.reviewboard.kde.org/r/125094/#comment59318>

    Call slotHiddenFilesShownChanged(m_currentView->hiddenFilesShown()) and change the icon, text and tool tip text in slotHiddenFilesShownChanged instead. (so that the action has the right icon and text even when 'show hidden files' was changed by loading the folder settings)



src/views/dolphinviewactionhandler.cpp (lines 482 - 488)
<https://git.reviewboard.kde.org/r/125094/#comment59319>

    Not needed anymore when done via slotHiddenFilesShownChanged -> Revert please


- Emmanuel Pescosta


On Sept. 14, 2015, 9:41 p.m., Roman Gilg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125094/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 9:41 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Icon based on 'edit-copy.svg'. Sorry, didn't know how to add the additionally breeze repository for the svg-files.
> First review request. Be nice please. :)
> 
> 
> Diffs
> -----
> 
>   src/views/dolphinviewactionhandler.h eb375b5 
>   src/views/dolphinviewactionhandler.cpp ac538a6 
> 
> Diff: https://git.reviewboard.kde.org/r/125094/diff/
> 
> 
> Testing
> -------
> 
> Tested on Arch, Plasma 5.4.
> 
> 
> File Attachments
> ----------------
> 
> hidden-files.svg (16, breeze)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/b35b6f89-4d89-4434-add7-b38ed2ae0aa1__hidden-files.svg
> hidden-files.svg (22, breeze)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/a15289c8-9721-40ce-b5ce-0047d5877e08__hidden-files.svg
> hidden-files.svg (16, breeze-dark)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/8d4c2940-1b3f-43b1-893e-09f49cb6f4aa__hidden-files.svg
> hidden-files.svg (22, breeze-dark)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/ce296c59-141a-4b50-90bf-d2a1c6e215d0__hidden-files.svg
> Demonstration
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/c731d844-9525-415d-9226-743fea6f5727__change.png
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150926/bd6a2102/attachment.htm>