Review Request 125094: Adding icon to show hidden files

Roman Gilg subdiff at gmail.com
Mon Sep 14 20:41:28 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125094/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 9:41 p.m.)


Review request for Dolphin.


Changes
-------

Using the icons "hint" and "visibility", which are already part of the breeze icon set.


Repository: dolphin


Description
-------

Icon based on 'edit-copy.svg'. Sorry, didn't know how to add the additionally breeze repository for the svg-files.
First review request. Be nice please. :)


Diffs (updated)
-----

  src/views/dolphinviewactionhandler.h eb375b5 
  src/views/dolphinviewactionhandler.cpp ac538a6 

Diff: https://git.reviewboard.kde.org/r/125094/diff/


Testing
-------

Tested on Arch, Plasma 5.4.


File Attachments
----------------

hidden-files.svg (16, breeze)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/b35b6f89-4d89-4434-add7-b38ed2ae0aa1__hidden-files.svg
hidden-files.svg (22, breeze)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/a15289c8-9721-40ce-b5ce-0047d5877e08__hidden-files.svg
hidden-files.svg (16, breeze-dark)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/8d4c2940-1b3f-43b1-893e-09f49cb6f4aa__hidden-files.svg
hidden-files.svg (22, breeze-dark)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/ce296c59-141a-4b50-90bf-d2a1c6e215d0__hidden-files.svg
Demonstration
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/c731d844-9525-415d-9226-743fea6f5727__change.png


Thanks,

Roman Gilg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150914/44a52daf/attachment.htm>


More information about the kfm-devel mailing list