Review Request 124984: Only save modified Details View column widths to disk after the mouse button was released

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124984/
-----------------------------------------------------------

(Updated Sept. 3, 2015, 6:36 nachm.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 351846
    https://bugs.kde.org/show_bug.cgi?id=351846


Repository: dolphin


Description
-------

When resizing Details View columns by dragging the handle between two column headers, the KItemListHeaderWidget signals the new width after every mouse move event. This is necessary to update the view immediately, but saving the new width to disk after every mouse move causes a lot of write operations and may slow down the resizing operation considerably.

I propose to introduce a new signal, which is emitted after the resize operation is finished. When dragging the handle between the column headers, this signal is emitted after the mouse button is released. When double-clicking the handle, the signal is emitted immediately.


Diffs
-----

  src/kitemviews/kitemlistheader.h cc2b747 
  src/kitemviews/kitemlistheader.cpp a3fa14d 
  src/kitemviews/private/kitemlistheaderwidget.h 307def7 
  src/kitemviews/private/kitemlistheaderwidget.cpp 45ce4e7 
  src/views/dolphinview.h 24b560f 
  src/views/dolphinview.cpp d302358 

Diff: https://git.reviewboard.kde.org/r/124984/diff/


Testing
-------

The log message about writing the view properties to disk now appears only once after the resize operation. Tried different ways to resize the columns (drag, double-click, enable automatic column widths), went to another folder and then back, and verified that the widths are as expected.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150903/326b7332/attachment.htm>