Review Request 124670: Scrolling fixes for Dolphin

[Maxim Mikityanskiy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124670/
-----------------------------------------------------------

(Updated Sept. 1, 2015, 7:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Changes
-------

Submitted with commit 10944d4194439759b71a6ebc01cc8478d92e6521 by Emmanuel Pescosta on behalf of Maxim Mikityanskiy to branch master.


Repository: dolphin


Description
-------

KItemListSmoothScroller::handleWheelEvent has some issues.

At first, when I scroll file list holding mouse over the list, one mouse wheel tick corresponds to 1/4 page interval, but when I hover on QScrollBar, one wheel tick corresponds to 1 page interval.

At second, in KItemListSmoothScroller::eventFilter we don't return true, so that QScrollBar also handles this event, and total scroll interval is m_scrollBar->pageStep() + m_scrollBar->singleStep().

At third, when I use touchpad that supports smooth scrolling via XInput2, and I hover it over QScrollBar, I can only scroll content if I move my fingers very fast, because numSteps = event->delta() / 8 / 15 is just zero unless I move very fast (event->delta() in this case is less than 120).

At fourth, holding Shift while scrolling has no effect when holding mouse over QScrollBar in contrast to scrolling faster when holding mouse over file list.

The patch eliminates all these issues making the behavior of KItemListSmoothScroller the same as in KItemListContainer::wheelEvent, adding support for QWheelEvent::pixelDelta() and removing usage of deprecated QWheelEvent::delta().


Diffs
-----

  src/kitemviews/private/kitemlistsmoothscroller.cpp e70f478 

Diff: https://git.reviewboard.kde.org/r/124670/diff/


Testing
-------


Thanks,

Maxim Mikityanskiy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150901/1fed6da0/attachment.htm>