Review Request 125675: Use the new KOverlayIconPlugin interface from KIO::Widgets

[Olivier Goffart]

> On Okt. 19, 2015, 12:25 nachm., Aleix Pol Gonzalez wrote:
> > src/CMakeLists.txt, line 139
> > <https://git.reviewboard.kde.org/r/125675/diff/2/?file=411727#file411727line139>
> >
> >     Why's that change?

So it finds the kio_version.h.   All the framework add $PREFIX/include/KF5 in the ionclude paths.  But the only file for which that matters is XXX_version.h  and since we are using kio_version.h, it is important to have the path where kio is installed first before the system's include paths.


> On Okt. 19, 2015, 12:25 nachm., Aleix Pol Gonzalez wrote:
> > src/kitemviews/kfileitemmodelrolesupdater.h, line 343
> > <https://git.reviewboard.kde.org/r/125675/diff/2/?file=411728#file411728line343>
> >
> >     Isn't the cool thing nowadays to use QVector? :)

It does not matter in this case since it is a list of pointer.  But yes.


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125675/#review87069
-----------------------------------------------------------


On Okt. 19, 2015, 11:14 vorm., Olivier Goffart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125675/
> -----------------------------------------------------------
> 
> (Updated Okt. 19, 2015, 11:14 vorm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Depends on, https://git.reviewboard.kde.org/r/125436
> 
> Replaces https://git.reviewboard.kde.org/r/125136/
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodelrolesupdater.cpp 14e3015 
>   src/CMakeLists.txt 413260b 
>   src/kitemviews/kfileitemmodelrolesupdater.h 6e7559f 
> 
> Diff: https://git.reviewboard.kde.org/r/125675/diff/
> 
> 
> Testing
> -------
> 
> Tested with owncloud plugin.
> 
> 
> Thanks,
> 
> Olivier Goffart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151019/f3ff44b4/attachment.htm>