Review Request 125675: Use the new KOverlayIconPlugin interface from KIO::Widgets

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125675/#review87069
-----------------------------------------------------------



src/CMakeLists.txt (line 139)
<https://git.reviewboard.kde.org/r/125675/#comment59844>

    Why's that change?



src/kitemviews/kfileitemmodelrolesupdater.h (line 343)
<https://git.reviewboard.kde.org/r/125675/#comment59845>

    Isn't the cool thing nowadays to use QVector? :)


Other than my nitpicking, +1

- Aleix Pol Gonzalez


On Oct. 19, 2015, 1:14 p.m., Olivier Goffart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125675/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 1:14 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Depends on, https://git.reviewboard.kde.org/r/125436
> 
> Replaces https://git.reviewboard.kde.org/r/125136/
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodelrolesupdater.cpp 14e3015 
>   src/CMakeLists.txt 413260b 
>   src/kitemviews/kfileitemmodelrolesupdater.h 6e7559f 
> 
> Diff: https://git.reviewboard.kde.org/r/125675/diff/
> 
> 
> Testing
> -------
> 
> Tested with owncloud plugin.
> 
> 
> Thanks,
> 
> Olivier Goffart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151019/71d24a6f/attachment.htm>