Review Request 125879: svn plugin bug 337946

[Anthony Fieroni]

> On Ноев. 2, 2015, 4:50 след обяд, Emmanuel Pescosta wrote:
> > svn/fileviewsvnplugin.cpp, lines 207-210
> > <https://git.reviewboard.kde.org/r/125879/diff/1/?file=413367#file413367line207>
> >
> >     This is not needed, if a item has version != NormalVersion then line 200 will be reached -> returns the item version from the hash table.

No, you must debug if not trust me, but i'm right. :) Let see what returns svn. We have working copy and unversioned dir test and file test1 in that dir. Result is
svn staus .
? test
svn status ./test
? test
SVN not indicate for files in unversioned dir then file ./test/test1 is NormalVersion. Line 200 will NOT be reached cause svn is not tell anything for this file :) Then we mest check like in example.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125879/#review87873
-----------------------------------------------------------


On Окт. 30, 2015, 6:56 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125879/
> -----------------------------------------------------------
> 
> (Updated Окт. 30, 2015, 6:56 преди обяд)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Dolphin ask for item status in Unversioned path
> 
> 
> Diffs
> -----
> 
>   svn/fileviewsvnplugin.cpp faf6a0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125879/diff/
> 
> 
> Testing
> -------
> 
> I show possible fix:
> When plugin return 'Unversioned' for directory Dolphin must stop ask, case example:
> svn status
> ?       test
> Then all files in test will be NormalVersion. Dolphin load single plugin per view, for me must be plugin for every directory that contains KVersionControlPlugin::fileName(). We can fix it in plugin svn by checking if item is directory and Unversioned to add all it content in m_versionInfoHash. Or to check for 'svn: warning: W155010: The node... was not found' cause right now this is NormalVersion :)
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151102/b193da89/attachment.htm>