Review Request 125879: svn plugin bug 337946

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125879/#review87873
-----------------------------------------------------------



svn/fileviewsvnplugin.cpp (line 206)
<https://git.reviewboard.kde.org/r/125879/#comment60289>

    The comment is fine.
    
    In FileViewSvnPlugin::beginRetrieval there is a comment that all items with version != NormalVersion are added to the hash table.



svn/fileviewsvnplugin.cpp (lines 207 - 210)
<https://git.reviewboard.kde.org/r/125879/#comment60290>

    This is not needed, if a item has version != NormalVersion then line 200 will be reached -> returns the item version from the hash table.


- Emmanuel Pescosta


On Oct. 30, 2015, 5:56 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125879/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 5:56 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Dolphin ask for item status in Unversioned path
> 
> 
> Diffs
> -----
> 
>   svn/fileviewsvnplugin.cpp faf6a0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125879/diff/
> 
> 
> Testing
> -------
> 
> I show possible fix:
> When plugin return 'Unversioned' for directory Dolphin must stop ask, case example:
> svn status
> ?       test
> Then all files in test will be NormalVersion. Dolphin load single plugin per view, for me must be plugin for every directory that contains KVersionControlPlugin::fileName(). We can fix it in plugin svn by checking if item is directory and Unversioned to add all it content in m_versionInfoHash. Or to check for 'svn: warning: W155010: The node... was not found' cause right now this is NormalVersion :)
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151102/399bc598/attachment.htm>