Review Request 123643: Move away from Baloo::Term

[Vishesh Handa]

> On May 6, 2015, 7:26 a.m., Emmanuel Pescosta wrote:
> > src/search/dolphinfacetswidget.cpp, line 184
> > <https://git.reviewboard.kde.org/r/123643/diff/1/?file=366480#file366480line184>
> >
> >     split by " AND "?

AND is typically implicit. I added it for clarity before. It being present/absent here doesn't make a difference.

I can add it or remove it from the above function. Your choice :)


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123643/#review79945
-----------------------------------------------------------


On May 6, 2015, 1:01 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123643/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 1:01 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Baloo is set to become a framework and wants to only export the bare
>     minimum number of classes as it will need to provide ABI + API
>     guarentees forever. The Term class is now no longer exported. It can be
>     added back again.
> 
> 
> Diffs
> -----
> 
>   src/search/dolphinfacetswidget.h 03fb127 
>   src/search/dolphinfacetswidget.cpp b183eb8 
>   src/search/dolphinsearchbox.cpp b67d1e6 
> 
> Diff: https://git.reviewboard.kde.org/r/123643/diff/
> 
> 
> Testing
> -------
> 
> Searching seems to work.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150506/5327c418/attachment.htm>