Review Request 123138: Remove deprecated X scaling of QPixmaps

David Edmundson david at davidedmundson.co.uk
Tue Mar 31 14:20:20 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123138/
-----------------------------------------------------------

(Updated March 31, 2015, 1:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Changes
-------

Submitted with commit de84f223d4408dc1eaf6f15ebeed2e8acf49ad4c by David Edmundson to branch master.


Repository: dolphin


Description
-------

QPixmaps are no longer X pixmaps so this won't ever work anymore

At this point we can just remove the entire method and just use
somePixmap.scale() and potentially save a detach but that's a more invasive patch for once my other thing is merged.


Diffs
-----

  src/kitemviews/private/kpixmapmodifier.cpp c564ecc 

Diff: https://git.reviewboard.kde.org/r/123138/diff/


Testing
-------

builds


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150331/f8c42a47/attachment.htm>


More information about the kfm-devel mailing list