Review Request 123138: Remove deprecated X scaling of QPixmaps

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123138/#review78073
-----------------------------------------------------------

Ship it!


Thanks for the patch!

Can you please remove all the xrender bits from the cmake file and the config-X11.h.cmake as well in this commit?

- Emmanuel Pescosta


On March 26, 2015, 5:05 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123138/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 5:05 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> QPixmaps are no longer X pixmaps so this won't ever work anymore
> 
> At this point we can just remove the entire method and just use
> somePixmap.scale() and potentially save a detach but that's a more invasive patch for once my other thing is merged.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/private/kpixmapmodifier.cpp c564ecc 
> 
> Diff: https://git.reviewboard.kde.org/r/123138/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150326/b2e3d37d/attachment.htm>