Review Request 123395: Simplify startup split view handling
Frank Reininghaus
frank78ac at googlemail.com
Fri Apr 24 16:58:22 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123395/#review79462
-----------------------------------------------------------
Ship it!
Very nice idea, looks good :-)
- Frank Reininghaus
On April 17, 2015, 11:13 vorm., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123395/
> -----------------------------------------------------------
>
> (Updated April 17, 2015, 11:13 vorm.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> * Instead of setting and resetting GeneralSettings's split view option, just pass it on to openFiles/openDirectories.
> * Require at least one url in openFiles/openDirectories
>
>
> Diffs
> -----
>
> src/dolphinmainwindow.h 5066657
> src/dolphinmainwindow.cpp da6c531
> src/dolphintabwidget.h a84b7fa
> src/dolphintabwidget.cpp 5b26359
> src/main.cpp 1c0fdab
>
> Diff: https://git.reviewboard.kde.org/r/123395/diff/
>
>
> Testing
> -------
>
> Setting split and/or select option still works as before :)
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150424/b777b90a/attachment.htm>
More information about the kfm-devel
mailing list