Review Request 123395: Simplify startup split view handling

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Fri Apr 17 12:13:19 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123395/
-----------------------------------------------------------

(Updated April 17, 2015, 1:13 p.m.)


Review request for Dolphin.


Changes
-------

Fixed wrong comments


Repository: dolphin


Description
-------

* Instead of setting and resetting GeneralSettings's split view option, just pass it on to openFiles/openDirectories.
* Require at least one url in openFiles/openDirectories


Diffs (updated)
-----

  src/dolphinmainwindow.h 5066657 
  src/dolphinmainwindow.cpp da6c531 
  src/dolphintabwidget.h a84b7fa 
  src/dolphintabwidget.cpp 5b26359 
  src/main.cpp 1c0fdab 

Diff: https://git.reviewboard.kde.org/r/123395/diff/


Testing
-------

Setting split and/or select option still works as before :)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150417/bb06feff/attachment.htm>


More information about the kfm-devel mailing list