Review Request 123253: dolphin: Navigate to parent folder selects child folder

[Gregor Mi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/
-----------------------------------------------------------

(Updated April 17, 2015, 5:48 p.m.)


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

associate bug report


Bugs: 335616
    https://bugs.kde.org/show_bug.cgi?id=335616


Repository: dolphin


Description
-------

This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".

In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.


Diffs
-----

  src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7 
  src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe 
  src/tests/kfileitemmodeltest.cpp eba32e1e1caa341e1db26399b4027a86614309fc 
  src/urlutil.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123253/diff/


Testing
-------

- unit test passes
- Played around with dolphin: enter URL manually, navigate via click in the item view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, Backspace


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150417/029f6dd4/attachment.htm>