Review Request 123253: dolphin: Navigate to parent folder selects child folder

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review79134
-----------------------------------------------------------


Thanks for your detailed reply! I'm still not quite convinced that the proposed behavior is what most users would expect. If I'm in a subfolder somewhere in the /usr/include hierarchy, and then I enter /usr/include in the location bar, then I want to see the first subfolders of /usr/include (i.e., the view scrolled to the top). Seeing the view scrolled down to a folder which happens to be an indirect parent of the previous folder would surprise me.

But even if we assume that many users would like the feature, then I see the risk that there will be bugs in the future because the history handling of KUrlNavigator and the "last URL" handling in DolphinViewContainer might interact in unexpected ways.

I think that changing KUrlNavigator such that interprets "up" as "back" if it seems appropriate (or that it creates a new history entry, but copies the view state data from the "back" entry - I don't know what's better) is less dangerous and would solve most problems that users currently see with the "up" behavior.

I have expressed all my thoughts on this issue in detail now - I'm curious what others think! And in any case, I appreciate all the effort you put into making KDE better :-)

- Frank Reininghaus


On April 4, 2015, 1:17 nachm., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
> 
> (Updated April 4, 2015, 1:17 nachm.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".
> 
> In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7 
>   src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe 
>   src/tests/kfileitemmodeltest.cpp eba32e1e1caa341e1db26399b4027a86614309fc 
>   src/urlutil.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
> 
> 
> Testing
> -------
> 
> - unit test passes
> - Played around with dolphin: enter URL manually, navigate via click in the item view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, Backspace
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150417/aa5765f4/attachment.htm>