Review Request 123278: Enable translation scripting for date groups

Alexander Potashev aspotashev at gmail.com
Fri Apr 10 00:33:16 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123278/#review78732
-----------------------------------------------------------


Lasse,

Yes, this is what I meant. Hoping this is better.

Can you please wrap the long lines to meet the coding style [1]? It says "Try to keep lines shorter than 100 characters, inserting line breaks as necessary".

[1] https://techbase.kde.org/Policies/Kdelibs_Coding_Style

- Alexander Potashev


On Апрель 9, 2015, 9:54 п.п., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123278/
> -----------------------------------------------------------
> 
> (Updated Апрель 9, 2015, 9:54 п.п.)
> 
> 
> Review request for Dolphin and Localization and Translation (l10n).
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This allows to work around limitations in Qt's date formatting.
> 
> Examples:
> 
> * Uppercasing the first character in a string because it's a title: Weekday and month names returned by QDateTime::toString are usually lowercase.
> * Correcting the noun case of a month name from "of [month]" to "in [month]" in Finnish: "of [month]" is correct when talking about a specific day, but wrong when talking about a specific month.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.cpp eac3ddf 
> 
> Diff: https://git.reviewboard.kde.org/r/123278/diff/
> 
> 
> Testing
> -------
> 
> Checked that grouping by date still worked.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150409/2e6e46db/attachment.htm>


More information about the kfm-devel mailing list