Review Request 121087: Use deleteLater() to delete the selection toggle in KItemListWidget::slotHoverAnimationFinished()

[Frank Reininghaus]

> On Nov. 9, 2014, 6:40 nachm., Christoph Feck wrote:
> > > doesn't make anything worse.
> > 
> > There is one subtle difference between delete and deleteLater, though, which indeed might make things worse: only delete is save to be called on a null ptr.

You're right, of course - thanks Christoph! I've added a safety check in http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=c65cc9207ac8ea9796f993458443a07bbcb87257


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121087/#review70123
-----------------------------------------------------------


On Nov. 9, 2014, 5:11 nachm., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121087/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2014, 5:11 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 334785
>     http://bugs.kde.org/show_bug.cgi?id=334785
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This patch should make a crash with a backtrace as provided in the bug report impossible. I'm not sure if this would really prevent the crash - it looks like the actual cause of the problem could be in QGraphicsView or anywhere else. But I'm pretty sure that this change doesn't make anything worse.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistwidget.cpp e7d2951 
> 
> Diff: https://git.reviewboard.kde.org/r/121087/diff/
> 
> 
> Testing
> -------
> 
> Hovering and un-hovering icons and selection toggles works as before.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141109/4f110e5e/attachment.htm>