Review Request 118207: Prevent that the translation of Places items is lost if a Dolphin window is closed

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118207/#review58186
-----------------------------------------------------------


This review has been submitted with commit 8f0202514bf692d6b9b046063392151ee10e364c by Frank Reininghaus to branch KDE/4.13.

- Commit Hook


On May 19, 2014, 4:33 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118207/
> -----------------------------------------------------------
> 
> (Updated May 19, 2014, 4:33 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 334999
>     http://bugs.kde.org/show_bug.cgi?id=334999
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> If the "Places" are updated outside the current Dolphin process, PlacesItemModel::updateBookmarks() is called, which invokes PlacesItem::setBookmark(const KBookmark& bookmark) for each item. This commit ensures that the correct translation is used for system bookmarks like "Root", "Network", etc.
> 
> Without this patch, all Places entries in the remaining Dolphin windows will switch to US English if one of multiple windows is closed.
> 
> Note that another fix has been pushed to master some time ago, but I think that this solution is better. See http://lists.kde.org/?t=139660468400004&r=1&w=2 for details.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitem.cpp 41f22cc 
> 
> Diff: https://git.reviewboard.kde.org/r/118207/diff/
> 
> 
> Testing
> -------
> 
> Fixes the problem for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140520/f12ea1c5/attachment.htm>