Review Request 118207: Prevent that the translation of Places items is lost if a Dolphin window is closed

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118207/
-----------------------------------------------------------

(Updated May 20, 2014, 6:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 334999
    http://bugs.kde.org/show_bug.cgi?id=334999


Repository: kde-baseapps


Description
-------

If the "Places" are updated outside the current Dolphin process, PlacesItemModel::updateBookmarks() is called, which invokes PlacesItem::setBookmark(const KBookmark& bookmark) for each item. This commit ensures that the correct translation is used for system bookmarks like "Root", "Network", etc.

Without this patch, all Places entries in the remaining Dolphin windows will switch to US English if one of multiple windows is closed.

Note that another fix has been pushed to master some time ago, but I think that this solution is better. See http://lists.kde.org/?t=139660468400004&r=1&w=2 for details.


Diffs
-----

  dolphin/src/panels/places/placesitem.cpp 41f22cc 

Diff: https://git.reviewboard.kde.org/r/118207/diff/


Testing
-------

Fixes the problem for me.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140520/de3c4d84/attachment.htm>