Review Request 117021: Fix Bug 332159 - dolphin does not remember scroll position when going back

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon Mar 24 15:19:23 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117021/
-----------------------------------------------------------

Review request for Dolphin.


Bugs: 332159
    http://bugs.kde.org/show_bug.cgi?id=332159


Repository: kde-baseapps


Description
-------

Fix Bug 332159 - dolphin does not remember scroll position when going back

DolphinView::updateViewState will be called multiple times in some special cases,
so we only reset the restored contents position if we have successfully reached it.


Diffs
-----

  dolphin/src/views/dolphinview.cpp 2769d67 

Diff: https://git.reviewboard.kde.org/r/117021/diff/


Testing
-------

Works. 

See Ashish's comment #5 in the bug report:

 Ashish 2014-03-23 19:02:46 CET
I can reproduce this only when the 1st folder has "Show hidden files" enabled. 
Step 1: Enable Show Hideen Files in say, home folder. 
2: Scroll down, open any folder. 
3: click back. We reach the top position in home folder. When Hidden files is not enabled, clicking on back remembers the scroll position. 
Version tested: 4.12.3 on Ubuntu 13.10


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140324/67208a2d/attachment.htm>


More information about the kfm-devel mailing list