Review Request 117015: Dolphin Facet Widget: Convert type selection into radio buttons

Vishesh Handa me at vhanda.in
Mon Mar 24 13:35:29 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117015/
-----------------------------------------------------------

(Updated March 24, 2014, 1:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------


    Dolphin Facet Widget: Convert type selection into radio buttons

    They were previously checkboxes. Most files cannot have more than 1 type
    considering that the exposed types were "Document", "Image", "Video" and
    "Audio".

    Also, it is not very simple in baloo to search through ORs for types.
    Not through the exposed API anyway.


Diffs
-----

  dolphin/src/search/dolphinfacetswidget.h 526fe1c 
  dolphin/src/search/dolphinfacetswidget.cpp aec84d3 

Diff: https://git.reviewboard.kde.org/r/117015/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140324/34cc4e0c/attachment.htm>


More information about the kfm-devel mailing list