Review Request 116805: filenamesearch: use mime type inheritance to find out if a file contains plain text that can be searched

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116805/
-----------------------------------------------------------

(Updated March 16, 2014, 5:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 332143
    http://bugs.kde.org/show_bug.cgi?id=332143


Repository: kde-baseapps


Description
-------

When searching "by content", we only search in files whose mime type starts with "text/", to prevent that much time is wasted reading binary files, in which searching makes no sense.

Unfortunately, this prevents that shell scripts are being searched.

I propose to use mime type inheritance instead, and include all mime types in the search which inherit from "text/plain":

http://api.kde.org/4.12-api/kdelibs-apidocs/kdecore/html/classKMimeType.html#a0ca33f89a8381dd331c23cda15294da1


Diffs
-----

  dolphin/src/search/filenamesearchprotocol.cpp 4d6f59f 

Diff: https://git.reviewboard.kde.org/r/116805/diff/


Testing
-------

Shell scripts are now found when searching "by content".


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140316/780607b8/attachment.htm>