Review Request 116805: filenamesearch: use mime type inheritance to find out if a file contains plain text that can be searched

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116805/#review53075
-----------------------------------------------------------


This review has been submitted with commit c52ba9446b05e6bc7f890daac406659a9c37c562 by Frank Reininghaus to branch KDE/4.12.

- Commit Hook


On March 15, 2014, 9:49 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116805/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 9:49 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 332143
>     http://bugs.kde.org/show_bug.cgi?id=332143
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> When searching "by content", we only search in files whose mime type starts with "text/", to prevent that much time is wasted reading binary files, in which searching makes no sense.
> 
> Unfortunately, this prevents that shell scripts are being searched.
> 
> I propose to use mime type inheritance instead, and include all mime types in the search which inherit from "text/plain":
> 
> http://api.kde.org/4.12-api/kdelibs-apidocs/kdecore/html/classKMimeType.html#a0ca33f89a8381dd331c23cda15294da1
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/filenamesearchprotocol.cpp 4d6f59f 
> 
> Diff: https://git.reviewboard.kde.org/r/116805/diff/
> 
> 
> Testing
> -------
> 
> Shell scripts are now found when searching "by content".
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140316/ed54da05/attachment.htm>