Review Request 106827: Fix Bug 304643 - selected place looks ugly and incomplete

[Frank Reininghaus]

Hi,


2014-06-12 2:43 GMT+02:00 Emmanuel Pescosta <emmanuelpescosta099 at gmail.com>:
>
> This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106827/
>
> On June 5th, 2013, 8:02 p.m. CEST, Frank Reininghaus wrote:
>
> Just for the record, I have not completely forgotton about this issue, even though I never said anything about it recently. It's just that there are always so many incoming bug reports, emails, and other things, and only very little time to handle all this.
>
> I am convinced now that the tinting is really a stupid idea, and now that the FolderView people have copied it, I think it's time to change it. I had this in mind on my "Things that should be looked into at least before the 4.11 RCs" list already.
>
> I think the best approach would be just go back to the Dolpin 1.x behaviour (equal to the file dialog), not tint the icons/previews, and draw a blue rectangle around the selected item. Nuno's idea sounds also interesting, but maybe this is something to consider for the frameworks era - I think that we should not go too far away from the file dialog design just now.
>
> On February 5th, 2014, 4:39 p.m. CET, Emmanuel Pescosta wrote:
>
> > "Things that should be looked into at least before the 4.11 RCs"
> Maybe something for 4.13? ;)
>
> On February 5th, 2014, 5:28 p.m. CET, Frank Reininghaus wrote:
>
> Both Christoph and I did look into it at some point, see
>
> https://bugs.kde.org/show_bug.cgi?id=309722
>
> Christoph argued that it might be better to fix
>
> https://bugs.kde.org/show_bug.cgi?id=299328
>
> first, and I think that this makes sense. However, my attempts to find out the root cause of that one have been unsuccessful so far.
>
> Selection toggle ... done
>
> Time to reopen this review request or should we change the
> whole selection rendering?
>
> https://3.bp.blogspot.com/-HcuLZWnyZ14/U5gFeRj2EAI/AAAAAAAAM_8/-NlS8FKTC4Y/s1600/plasma50b2-dolphin.png
> I'm asking because of this screenshot, the "incomplete" effect is much more visible (white background,
> solid line, ...) than in Dolphin 4.x.

I agree that it would be good to fix this issue soon. For the Details
and Compact View (including the Places Panel), I indeed see no reason
for not extending the selection rectangle to the icon area and
removing the icon tinting.

The more interesting part is the Icons View from my point of view.

@Christoph: actually, I quite like your idea from
https://bugs.kde.org/show_bug.cgi?id=309722 (for everyone who did not
follow that report, there is a screenshot at [1]).
Do you think that we could use it? What do others think? Do you think
that we should discuss this with, e.g., desigers before the change is
pushed?

As far as I am concerned, we could also just make the change and then
see what people who test it think about it. I think it's rather
unlikely that there are many users who like the ugly tinted icons more
than Christoph's suggestion.

Regards,
Frank

[1] http://bugsfiles.kde.org/attachment.cgi?id=83419