Review Request 106827: Fix Bug 304643 - selected place looks ugly and incomplete

[Emmanuel Pescosta]

> On June 5, 2013, 8:02 p.m., Frank Reininghaus wrote:
> > Just for the record, I have not completely forgotton about this issue, even though I never said anything about it recently. It's just that there are always so many incoming bug reports, emails, and other things, and only very little time to handle all this.
> > 
> > I am convinced now that the tinting is really a stupid idea, and now that the FolderView people have copied it, I think it's time to change it. I had this in mind on my "Things that should be looked into at least before the 4.11 RCs" list already.
> > 
> > I think the best approach would be just go back to the Dolpin 1.x behaviour (equal to the file dialog), not tint the icons/previews, and draw a blue rectangle around the selected item. Nuno's idea sounds also interesting, but maybe this is something to consider for the frameworks era - I think that we should not go too far away from the file dialog design just now.
> 
> Emmanuel Pescosta wrote:
>     > "Things that should be looked into at least before the 4.11 RCs"
>     Maybe something for 4.13? ;)
> 
> Frank Reininghaus wrote:
>     Both Christoph and I did look into it at some point, see
>     
>     https://bugs.kde.org/show_bug.cgi?id=309722
>     
>     Christoph argued that it might be better to fix
>     
>     https://bugs.kde.org/show_bug.cgi?id=299328
>     
>     first, and I think that this makes sense. However, my attempts to find out the root cause of that one have been unsuccessful so far.

Selection toggle ... done

Time to reopen this review request or should we change the
whole selection rendering?

https://3.bp.blogspot.com/-HcuLZWnyZ14/U5gFeRj2EAI/AAAAAAAAM_8/-NlS8FKTC4Y/s1600/plasma50b2-dolphin.png 
I'm asking because of this screenshot, the "incomplete" effect is much more visible (white background, 
solid line, ...) than in Dolphin 4.x. 


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106827/#review33817
-----------------------------------------------------------


On June 4, 2013, 6:39 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/106827/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 6:39 p.m.)
> 
> 
> Review request for Dolphin, Nuno Bento and Frank Reininghaus.
> 
> 
> Bugs: 304643
>     http://bugs.kde.org/show_bug.cgi?id=304643
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fix Bug 304643 - selected place looks ugly and incomplete
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistwidget.h 55181fa 
>   dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf 
>   dolphin/src/panels/folders/foldersitemlistwidget.cpp b4f9a5b 
>   dolphin/src/panels/places/placesitemlistwidget.h a2a88c1 
>   dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da 
> 
> Diff: https://git.reviewboard.kde.org/r/106827/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Old and new Dolphin Places look
>   https://git.reviewboard.kde.org/r/106827/s/779/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140612/fda3f26a/attachment.htm>