Review Request 118508: Make Dolphin windows with multiple tabs closable

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118508/
-----------------------------------------------------------

(Updated June 4, 2014, 7:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 335732
    http://bugs.kde.org/show_bug.cgi?id=335732


Repository: kde-baseapps


Description
-------

The return type and values of KMessageBox::createKMessageBox() have changed in KF5. We have to adjust the code in DolphinMainWindow::closeEvent(QCloseEvent* event) in order to make windows with multiple tabs closable.


Diffs
-----

  dolphin/src/dolphinmainwindow.cpp 049c440 

Diff: https://git.reviewboard.kde.org/r/118508/diff/


Testing
-------

All buttons in the confirmation dialog work as expected for me when trying to close a window with multiple tabs.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140604/b8c98140/attachment.htm>