Review Request 118508: Make Dolphin windows with multiple tabs closable

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118508/#review59238
-----------------------------------------------------------


This review has been submitted with commit 40599aaa3f4aeee9293acc692a08e839f4140d04 by Frank Reininghaus to branch frameworks.

- Commit Hook


On June 3, 2014, 7:43 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118508/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 7:43 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 335732
>     http://bugs.kde.org/show_bug.cgi?id=335732
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> The return type and values of KMessageBox::createKMessageBox() have changed in KF5. We have to adjust the code in DolphinMainWindow::closeEvent(QCloseEvent* event) in order to make windows with multiple tabs closable.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 049c440 
> 
> Diff: https://git.reviewboard.kde.org/r/118508/diff/
> 
> 
> Testing
> -------
> 
> All buttons in the confirmation dialog work as expected for me when trying to close a window with multiple tabs.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140604/286800d0/attachment.htm>