Review Request 118440: A quick shortcut to show/hide active panels in order to gain screen space

[Jos Poortvliet]

On Tuesday 03 June 2014 07:39:51 Frank Reininghaus wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118440/#review59044
> -----------------------------------------------------------
> 
> 
> Thanks for the patch!
> 
> I see that such a feature can be useful in some situations, but I'm not sure
> if it will really be useful enough to justify its inclusion in Dolphin.

May I suggest another solution: when a dolphin window gets small, why not hide 
the panels, exactly like James proposes, but automatically. And restore when 
there is enough space.

It is pointless to have two huge panels and a single row of icons (or even 
less) - hiding the panels is the sane thing to do. No need to force the user 
to use a (more or less obscure) shortcut to do it by hand...

/J

> - Frank Reininghaus
> 
> On June 1, 2014, 7:56 p.m., James Abtahi wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/118440/
> > -----------------------------------------------------------
> > 
> > (Updated June 1, 2014, 7:56 p.m.)
> > 
> > 
> > Review request for Dolphin.
> > 
> > 
> > Repository: kde-baseapps
> > 
> > 
> > Description
> > -------
> > 
> > In smaller screens, various panels of Dolphin can occupy a good portion of
> > the screen. At many situation, I just want to quickly hide all those
> > panels to have a better control over the content and make them reappear
> > again with just one quick shortcut. At the moment, there only solution is
> > to use all the F4, F7, F9, and F11 individually to achieve this which is
> > a very inefficient and irritating solution.
> > 
> > NOTE: I'm NOT looking for just simply toggling panel's visibility on and
> > off (that's too simple to implement). The mechanism I'm looking for is
> > that Dolphin saves the visibility of current panels, hide them when the
> > assigned key (e.g. ESC) is pressed, and make EXACTLY the same previously
> > shown panels to reappear again when ESC is pressed. A similar (yet
> > simpler) solution exist in Nemo (Cinommon's file manager).
> > 
> > The "panelvisibility.patch" does the job very well and works with the
> > latest Dolphin 4.99.0. There are some refinements yet to be done for this
> > patch but first I wanted to know what you think about this feature
> > getting added to mainstream Dolphin (really handy for people like me).
> > 
> > This feature is available through "View > Panels > Show/Hide Active
> > Panels" and ESC shortcut.
> > 
> > 
> > 
> > 
> > Diffs
> > -----
> > 
> >   dolphin/src/dolphinmainwindow.h 1192f6e
> >   dolphin/src/dolphinmainwindow.cpp 049c440
> >   dolphin/src/statusbar/dolphinstatusbar.cpp 9f17c8e
> > 
> > Diff: https://git.reviewboard.kde.org/r/118440/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > James Abtahi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140603/773f96bf/attachment.sig>