Review Request 119532: Prevent multiple connections between a single signal-slot pair

Arjun Ak arjunak234 at gmail.com
Wed Jul 30 14:07:30 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119532/
-----------------------------------------------------------

(Updated July 30, 2014, 1:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Multiple signal slot connections can cause wrong error message to be displayed

1) Click on any device in the places menu
2) Click cancel on the authentication dialogue
    Error message: "An error occurred while accessing '$DISK_LABEL'..."
3) Click on the same device again
    Error message: "An error occurred while accessing '$FIRST_ENTRY_IN_PANEL'..."
    
m_storageSetupInProgress is empty and therefore take returns 0.


Diffs
-----

  dolphin/src/panels/places/placesitemmodel.cpp 1f05e07 

Diff: https://git.reviewboard.kde.org/r/119532/diff/


Testing
-------


Thanks,

Arjun Ak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140730/5d9fb5e6/attachment.htm>


More information about the kfm-devel mailing list