Review Request 119532: Prevent multiple connections between a single signal-slot pair

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119532/#review63493
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks reasonable! I was not aware of this problem at all.

Should be fine for KDE/4.14, since it's a bug fix and not very intrusive.

- Frank Reininghaus


On July 29, 2014, 10:35 a.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119532/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 10:35 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Multiple signal slot connections can cause wrong error message to be displayed
> 
> 1) Click on any device in the places menu
> 2) Click cancel on the authentication dialogue
>     Error message: "An error occurred while accessing '$DISK_LABEL'..."
> 3) Click on the same device again
>     Error message: "An error occurred while accessing '$FIRST_ENTRY_IN_PANEL'..."
>     
> m_storageSetupInProgress is empty and therefore take returns 0.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 1f05e07 
> 
> Diff: https://git.reviewboard.kde.org/r/119532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140730/7b84d187/attachment.htm>