Review Request 119115: DolphinTabWidget

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Jul 9 21:40:31 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/
-----------------------------------------------------------

(Updated July 9, 2014, 10:40 p.m.)


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.

Removed the method for text squeezing because the QTabBar can do this automatically.

The tab sizes are different, any idea how to fix this?


Diffs (updated)
-----

  dolphin/src/CMakeLists.txt 7b0210a 
  dolphin/src/dolphinmainwindow.h 9c7f185 
  dolphin/src/dolphinmainwindow.cpp 41bd626 
  dolphin/src/dolphintabpage.h 95c02ed 
  dolphin/src/dolphintabpage.cpp c8e4263 
  dolphin/src/dolphintabwidget.h PRE-CREATION 
  dolphin/src/dolphintabwidget.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119115/diff/


Testing
-------

Works great so far.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140709/bd3e972c/attachment.htm>


More information about the kfm-devel mailing list