Review Request 119115: DolphinTabWidget

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/#review61609
-----------------------------------------------------------


Hmm something went wrong with the diff?!

So please review "DolphinTabBar" and "Avoid opening unused tabs which are closed again after startup has finished (when directory/file urls are given)" first so that I can commit them first, thanks! :)

- Emmanuel Pescosta


On July 4, 2014, 6:06 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119115/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 6:06 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.
> 
> Removed the method for text squeezing because the QTabBar can do this automatically.
> 
> The tab sizes are different, any idea how to fix this?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 518c8b7 
>   dolphin/src/dolphinmainwindow.h 7c3bff4 
>   dolphin/src/dolphinmainwindow.cpp d9fe645 
>   dolphin/src/dolphintabpage.h 95c02ed 
>   dolphin/src/dolphintabpage.cpp c8e4263 
>   dolphin/src/dolphintabwidget.h PRE-CREATION 
>   dolphin/src/dolphintabwidget.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119115/diff/
> 
> 
> Testing
> -------
> 
> Works great so far.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140704/bc954a19/attachment.htm>