Dolphin and Baloo

[Frank Reininghaus]

Hi,

2014-01-28 Vishesh Handa:
> Baloo is mostly just a library to access stuff. It does not need to be running
> for applications to use it - imagine sqlite.
>
> It does have a separate process `baloo_file` which is responsible for updating
> the index. But even if it crashes/whatever applications can still access all
> the data.

Thanks for the explanation. Do I understand correctly that this means
that the switch to Baloo will fix problems like

https://bugs.kde.org/show_bug.cgi?id=330117

(this is about Dolphin failing to show Nepomuk info in Details View if
the user logs in, and an earlier session is restored - Dolphin may
start up before Nepomuk is running then and fails to show roles that
require a "running Nepomuk")?


Here are a few more things:

1. Compilation fails here if Baloo is not installed. It seems that
HAVE_BALOO is defined nevertheless?

2. Coding style:

(a) Put {...} even around one-line statements after if (...) (see
KFileItemModelRolesUpdater::rolesData(const KFileItem&))

(b) Use

} else if (...) {

rather than

}
else if (...) {

(see KBalooRolesProvider::roleValues())

(c) KBalooRolesProvider: the indentation is inconsistent in "static
const PropertyInfo propertyInfoList[]"

Better indent the second part of each {..., ...} to the same common
multiple of 4 columns.

3. PlacesItemModel::PlacesItemModel(QObject* parent): the statement
"m_fileIndexingEnabled = true;" is redundant, right?

4. Could you point out why you commented out some code in
KFileItemModelRolesUpdater::applyChangedBalooRoles(const QString&
itemUrl), please?

5. About the FIXME comments in KFileItemModelRolesUpdater: I agree
that these things should be fixed because I don't like nested event
loops much. It should be quite straightforward to do, right? I don't
mind if it's fixed after merging the branch, but it should be done
before the next beta releases.


Thanks,
Frank