Review Request 115146: Don't show tooltips while inline-renaming.

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon Jan 20 16:43:42 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115146/
-----------------------------------------------------------

(Updated Jan. 20, 2014, 5:43 p.m.)


Review request for Dolphin.


Changes
-------

Only add hideToolTip() in renameSelectedItems()

@Frank: Thanks for the hint!


Bugs: 330126
    http://bugs.kde.org/show_bug.cgi?id=330126


Repository: kde-baseapps


Description
-------

Don't show tooltips while inline-renaming.

The logic to disable tooltips in some special cases was already there, so these changes should be really safe for 4.12.2 ;)


Diffs (updated)
-----

  dolphin/src/views/dolphinview.cpp 1416bb6 

Diff: https://git.reviewboard.kde.org/r/115146/diff/


Testing
-------

Works.

Hovering a item -> tooltip visible -> start renaming (with F2) -> tooltip hidden


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140120/03c8a6ba/attachment.htm>


More information about the kfm-devel mailing list