Review Request 115146: Don't show tooltips while inline-renaming.

[Emmanuel Pescosta]

> On Jan. 20, 2014, 4:29 p.m., Frank Reininghaus wrote:
> > Thanks for the patch. Why is the new member needed? No new tooltips are opened here while inline-renaming is active, so I would have expected that calling hideToolTip() in renameSelecteItems() is sufficient.

> No new tooltips are opened here while inline-renaming is active, so I would have expected that calling hideToolTip() in renameSelecteItems() is sufficient.
Oh yes, you are right. Only hideToolTip() in renameSelectedItems() does the same job.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115146/#review47801
-----------------------------------------------------------


On Jan. 20, 2014, 2:35 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115146/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 2:35 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 330126
>     http://bugs.kde.org/show_bug.cgi?id=330126
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Don't show tooltips while inline-renaming.
> 
> The logic to disable tooltips in some special cases was already there, so these changes should be really safe for 4.12.2 ;)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 1416bb6 
>   dolphin/src/views/dolphinview.h b43957f 
> 
> Diff: https://git.reviewboard.kde.org/r/115146/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> Hovering a item -> tooltip visible -> start renaming (with F2) -> tooltip hidden
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140120/1470f69d/attachment.htm>