Review Request 114957: Add support for getting a samba share's total size and free space through KIO, dolphin part

Mathias Tillman master.homer at gmail.com
Fri Jan 10 23:11:55 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114957/
-----------------------------------------------------------

(Updated Jan. 10, 2014, 11:11 p.m.)


Review request for Dolphin and David Faure.


Changes
-------

This should fix all of the issues, as well as clean up some names of functions and variables. 


Bugs: 245226
    http://bugs.kde.org/show_bug.cgi?id=245226


Repository: kde-baseapps


Description
-------

Added support for getting a samba share's total size and the current free space through a special KIO command. This is the dolphin part of the code, see #114956 for the other part.


Diffs (updated)
-----

  dolphin/src/statusbar/statusbarspaceinfo.h 1849462 
  dolphin/src/statusbar/statusbarspaceinfo.cpp 61b2833 

Diff: https://git.reviewboard.kde.org/r/114957/diff/


Testing
-------

I have tried browsing samba shares. I have not, however, done a lot of error checking (network down etc). But the code should be ready for that.


Thanks,

Mathias Tillman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140110/cd1aab97/attachment.htm>


More information about the kfm-devel mailing list