Review Request 114957: Add support for getting a samba share's total size and free space through KIO, dolphin part

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114957/#review47169
-----------------------------------------------------------



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33618>

    remove, unused (fortunately)



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33620>

    comment needs adjustment :)



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33622>

    spaces around <<



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33621>

    unused



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33623>

    remove spaces within ( ... )
    
    (kdelibs/kf5 coding style)



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33630>

    not needed for kio jobs



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33624>

    { ... } even for one-liners



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33625>

    the name "job" here is very confusing, it's not a KJob. This was in the orig code, but now that there's a KJob nearby....



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33629>

    success = false  should be handled in a different method, would be much more readable. The other args are irrelevant if success == false.
    And then the local var bool success can be removed, call error handling right away on error.



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33628>

    '{' on its own line for opening method implementation



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33627>

    space after if



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33626>

    static_cast<>, so the compiler can check it's valid


- David Faure


On Jan. 10, 2014, 8:02 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114957/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 8:02 p.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Added support for getting a samba share's total size and the current free space through a special KIO command. This is the dolphin part of the code, see #114956 for the other part.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/statusbarspaceinfo.h 1849462 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 61b2833 
> 
> Diff: https://git.reviewboard.kde.org/r/114957/diff/
> 
> 
> Testing
> -------
> 
> I have tried browsing samba shares. I have not, however, done a lot of error checking (network down etc). But the code should be ready for that.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140110/febcbef0/attachment.htm>