Review Request 116019: Fix Bug 330605 - Dropbox plugin prevents git plugin from working

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116019/#review50813
-----------------------------------------------------------

Ship it!


You're right, this optimization makes sense indeed. Thanks.

- Frank Reininghaus


On Feb. 25, 2014, 12:13 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116019/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 12:13 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 330605
>     http://bugs.kde.org/show_bug.cgi?id=330605
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fix Bug 330605 - Dropbox plugin prevents git plugin from working
> 
> Use scoring to find the best matching plugin for the given directory.
> 
> Instead of just returning the first matching plugin (upUrl case),
> add it to the map and find the best matching plugin afterwards.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 4d939ee 
> 
> Diff: https://git.reviewboard.kde.org/r/116019/diff/
> 
> 
> Testing
> -------
> 
> Phil Schaf has tested the patch and it works for him.
> 
> Thanks Phil!
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140225/ff1b7b3d/attachment.htm>