Review Request 116019: Fix Bug 330605 - Dropbox plugin prevents git plugin from working

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116019/
-----------------------------------------------------------

(Updated Feb. 25, 2014, 1:13 p.m.)


Review request for Dolphin.


Changes
-------

Fixed typo

Added upUrlCounter < bestScore check to the up url loop, it
makes no sense to continue the loop, when the upUrlCounter
is equal or bigger than the best score.


Bugs: 330605
    http://bugs.kde.org/show_bug.cgi?id=330605


Repository: kde-baseapps


Description
-------

Fix Bug 330605 - Dropbox plugin prevents git plugin from working

Use scoring to find the best matching plugin for the given directory.

Instead of just returning the first matching plugin (upUrl case),
add it to the map and find the best matching plugin afterwards.


Diffs (updated)
-----

  dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 4d939ee 

Diff: https://git.reviewboard.kde.org/r/116019/diff/


Testing
-------

Phil Schaf has tested the patch and it works for him.

Thanks Phil!


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140225/52bc341f/attachment.htm>