Review Request 115678: Make DolphinContextMenu independent

[Emmanuel Pescosta]

> On Feb. 17, 2014, 6:22 p.m., Frank Reininghaus wrote:
> > Well, I guess the main question is if the Folders Panel really needs a full-blown DolphinContextMenu. I'm really not sure.

In the current version, Dolphin has 3 different context menus.

Places panel context menu is good, because its context is too different.

But the folders panel context menu makes sense to change, because
you should be able to do nearly the same as in Dolphin View with folders (from my point of view).

Create new folders, open in new tab and open in new window should definitely be added in my opinion.
Some custom actions and services, like open as root, open terminal .... are also very helpful in the folders panel.

Also the user is very familiar with the DolphinContextMenu, so why not use it in the folders panel
too, because all actions from FoldersPanelContextMenu (+ create items, new tab, new window, ...) are already in DolphinContextMenu
and the layout will be exactly the same, so I think this is an improvement over the current situation - most people memorize the position of an item. 

So this was my point of view ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115678/#review50076
-----------------------------------------------------------


On Feb. 11, 2014, 8:24 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115678/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 8:24 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> * Removed all DolphinMainWindow and DolphinView dependencies in DolphinContextMenu.
> * Removed some code duplications in DolphinContextMenu.
> * Code cleanup in DolphinContextMenu.
> 
> We can now use DolphinContextMenu in other places too.
> 
> I hope this patch is not too huge for reviewing, but there was no good way to split it up.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.h 180f917 
>   dolphin/src/dolphincontextmenu.cpp f295de7 
>   dolphin/src/dolphinmainwindow.h cb97612 
>   dolphin/src/dolphinmainwindow.cpp 8473014 
>   dolphin/src/views/dolphinview.h 3731464 
>   dolphin/src/views/dolphinview.cpp 9f5f48a 
> 
> Diff: https://git.reviewboard.kde.org/r/115678/diff/
> 
> 
> Testing
> -------
> 
> Compiles. Works fine so far.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140221/d1f13713/attachment.htm>