Review Request 115678: Make DolphinContextMenu independent

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115678/#review50076
-----------------------------------------------------------


Well, I guess the main question is if the Folders Panel really needs a full-blown DolphinContextMenu. I'm really not sure.

- Frank Reininghaus


On Feb. 11, 2014, 7:24 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115678/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 7:24 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> * Removed all DolphinMainWindow and DolphinView dependencies in DolphinContextMenu.
> * Removed some code duplications in DolphinContextMenu.
> * Code cleanup in DolphinContextMenu.
> 
> We can now use DolphinContextMenu in other places too.
> 
> I hope this patch is not too huge for reviewing, but there was no good way to split it up.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.h 180f917 
>   dolphin/src/dolphincontextmenu.cpp f295de7 
>   dolphin/src/dolphinmainwindow.h cb97612 
>   dolphin/src/dolphinmainwindow.cpp 8473014 
>   dolphin/src/views/dolphinview.h 3731464 
>   dolphin/src/views/dolphinview.cpp 9f5f48a 
> 
> Diff: https://git.reviewboard.kde.org/r/115678/diff/
> 
> 
> Testing
> -------
> 
> Compiles. Works fine so far.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140217/17a0104f/attachment.htm>