File manager context menus

[Frank Reininghaus]

Hi David,

2014-08-22 9:46 GMT+02:00 David Faure:
> On Sunday 17 August 2014 23:02:24 Frank Reininghaus wrote:
>> > I have made two patches related to context menus
>> > (https://git.reviewboard.kde.org/r/115678/ and
>> > https://git.reviewboard.kde.org/r/115679/) some time ago, to make the
>> > DolpinContextMenu more independent, so that it can be reused in multiple
>> > places within Dolphin.
>> Yes, if we can remove code duplication by sharing the context menu
>> with others, I agree that using this shared menu also in other places,
>> like the Folders Panel, is worth considering :-)
>
> So what's your preferred approach? Starting from DolphinContextMenu (and
> extracting it into KIO), or starting from KonqPopupMenu?
>
> E.g. do you consider the visual appearance or the API of KonqPopupMenu
> particularly ugly? Otherwise it seems simpler to start from this one, it's
> more commonly used.

yes, I agree that starting from KonqPopupMenu makes sense then!

Regards,
Frank