Review Request 119799: New activities linking file item plugin

[Ivan Čukić]

> On Aug. 15, 2014, 8:19 p.m., David Edmundson wrote:
> > src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp, line 255
> > <https://git.reviewboard.kde.org/r/119799/diff/3/?file=305663#file305663line255>
> >
> >     Why are we making one database per file item plugin? We're using this read only as I understand it.
> >     
> >     Also if so we should set the mode to
> >     QSQLITE_OPEN_READONLY

The class gets destroyed after usage, so there should be only one live connection at a time.

I'm in the process of factoring out the database connection part because three different components are using them at the moment. I'll make a reference counted connection pool for it and all will be well. (though, in this case, not really necessary)

> QSQLITE_OPEN_READONLY
+1


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119799/#review64605
-----------------------------------------------------------


On Aug. 15, 2014, 9:48 a.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119799/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 9:48 a.m.)
> 
> 
> Review request for Dolphin, Plasma and Frank Reininghaus.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> New version of the file item plugin for the post nepomuk era and kf5.
> 
> The behaviour is changed compared to the previous one:
> - At first, it shows a submenu (named 'Activities') that contains the 'Loading...' text
> - When the popup is requested to be shown (hovered signal of the root action) it asynchronously loads the sub-actions.
> 
> It is much faster than the nepomuk-based one, and it does not  display the 'Loading...' item to the user at all.
> 
> 
> Diffs
> -----
> 
>   src/workspace/CMakeLists.txt bd4e636 
>   src/workspace/fileitemplugin/CMakeLists.txt d835aec 
>   src/workspace/fileitemplugin/FileItemLinkingPlugin.h ef7ad3b 
>   src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 5bcc141 
>   src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h 6fb9b13 
> 
> Diff: https://git.reviewboard.kde.org/r/119799/diff/
> 
> 
> Testing
> -------
> 
> Tested also with artificial slowing down with sleeps.
> Tested also when the activity manager is not running.
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140816/7deacfc7/attachment.htm>