Review Request 119115: DolphinTabWidget

[Emmanuel Pescosta]

> On Aug. 8, 2014, 9:12 a.m., Frank Reininghaus wrote:
> > Looks good now, thanks! I have just one very minor suggestion (see below), but feel free to ignore it if you prefer. Thank you very much for your work on this!

Thanks for reviewing this relatively large patches! ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/#review64031
-----------------------------------------------------------


On Aug. 10, 2014, 6:57 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119115/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 6:57 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 315904
>     http://bugs.kde.org/show_bug.cgi?id=315904
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.
> 
> Removed the method for text squeezing because the QTabBar can do this automatically.
> 
> The tab sizes are different, any idea how to fix this?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphintabwidget.cpp PRE-CREATION 
>   dolphin/src/CMakeLists.txt 7b0210a 
>   dolphin/src/dolphinmainwindow.h 6f37f42 
>   dolphin/src/dolphinmainwindow.cpp d321d3b 
>   dolphin/src/dolphintabpage.h 95c02ed 
>   dolphin/src/dolphintabpage.cpp 82be6d5 
>   dolphin/src/dolphintabwidget.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119115/diff/
> 
> 
> Testing
> -------
> 
> Works great so far.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140810/e43dc14e/attachment.htm>